Skip to content

docs: Add short new contributor tips for copying into pull requests #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Dec 21, 2022

I usually cut and paste a set of tips into issues that I mark as "good first issue" so I figured I'd put them into the docs directory so it was faster to find them when I needed them.

@terriko terriko added the documentation Documentation changes label Dec 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #2466 (8d713fc) into main (ab5c2fc) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2466   +/-   ##
=======================================
  Coverage   77.79%   77.79%           
=======================================
  Files         581      583    +2     
  Lines        9679     9689   +10     
  Branches     1319     1319           
=======================================
+ Hits         7530     7538    +8     
- Misses       1847     1849    +2     
  Partials      302      302           
Flag Coverage Δ
longtests 76.85% <ø> (-0.02%) ⬇️
win-longtests 75.27% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_json.py 72.41% <0.00%> (-17.25%) ⬇️
cve_bin_tool/checkers/__init__.py 95.55% <0.00%> (ø)
cve_bin_tool/checkers/doxygen.py 100.00% <0.00%> (ø)
test/test_data/doxygen.py 100.00% <0.00%> (ø)
cve_bin_tool/cli.py 66.23% <0.00%> (+0.96%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@terriko
Copy link
Contributor Author

terriko commented Dec 22, 2022

Thanks for reviewing, @BreadGenie ! Merge time now.

@terriko terriko merged commit 4b8b4be into intel:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants